add ReadOnly config option for read-only filesystems #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrylysov
reviewed
Nov 25, 2022
| @@ -16,8 +16,8 @@ func readGobFile(fsys fs.FileSystem, name string, v interface{}) error { | |||
| return dec.Decode(v) | |||
| } | |||
|
|
|||
| func writeGobFile(fsys fs.FileSystem, name string, v interface{}) error { | |||
| f, err := openFile(fsys, name, true) | |||
| func writeGobFile(fsys fs.FileSystem, name string, v interface{}, readOnly bool) error { | |||
There was a problem hiding this comment.
What would be the desired effect of writing to a file opened in read-only mode? Wouldn't it always fail?
| @@ -79,15 +79,15 @@ func parseSegmentName(name string) (uint16, uint64, error) { | |||
| } | |||
|
|
|||
| func (dl *datalog) openSegment(name string, id uint16, seqID uint64) (*segment, error) { | |||
| f, err := openFile(dl.opts.FileSystem, name, false) | |||
| f, err := openFile(dl.opts.FileSystem, name, false, dl.opts.ReadOnly) | |||
There was a problem hiding this comment.
Wondering if rather than modifying all openFile calls it would be cleaner to implement a new file system wrapper similar to fs.Sub? The wrapper would set os.O_RDONLY flags and implement a noop CreateLockFile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a ReadOnly config option to be able to put the database on a read-only filesystem.
Enabling this config options disables the Lockfile mechanism and sets all file access flags to
O_RDONLY.