Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate settings header section #325

Open
wants to merge 4 commits into
base: v2
Choose a base branch
from

Conversation

MasihTak
Copy link

@MasihTak MasihTak commented Feb 5, 2024

No description provided.

src/components/settings/header/Header.vue Outdated Show resolved Hide resolved
src/components/settings/header/Header.vue Outdated Show resolved Hide resolved
src/components/settings/header/Header.vue Outdated Show resolved Hide resolved
@MasihTak
Copy link
Author

MasihTak commented Feb 9, 2024

Should I also replace <VDivider class="my-3" /> with custom HTML code?

@aleksey-hoffman
Copy link
Owner

aleksey-hoffman commented Feb 9, 2024

Should I also replace <VDivider class="my-3" /> with custom HTML code?

I think we can just replace it with a border on the header. We already have a divider CSS variable.
Somehing like this:

padding-bottom: 16px;
border-bottom: 1px solid var(--divider-color);

@aleksey-hoffman
Copy link
Owner

Thanks Masih :)
I will add the final changes and merge it soon

@MasihTak
Copy link
Author

Pleasure is mine! 😇
The button component still requires some adjustments; for example, the variant is hardcoded and not dynamic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants