Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If being used for Groq, skip OpenAI-Organization header #473

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

drnic
Copy link
Contributor

@drnic drnic commented May 7, 2024

I've looked at using groq via langchain -> ruby-openai and was seeing a warning about me not setting OpenAI-Organization. If I run .compact on the headers, the warning seems to go away.

@drnic
Copy link
Contributor Author

drnic commented May 10, 2024

^ is this CI failure something I can fix?

@alexrudall
Copy link
Owner

@drnic no, I think I broke something. Will try and fix. Thanks for this PR!

.gitignore Outdated
@@ -14,7 +14,7 @@
/.yardoc
/_yardoc/
/doc/

/TAGS
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's TAGS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, it’s one of those metadata files that are spat out by a vscode plugin I have.

Perhaps there’s a way I can have it in a global ignore on my machine?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. You ok to yank this change from the PR? Or I can go find my laptop and do it

@alexrudall
Copy link
Owner

^ is this CI failure something I can fix?

I may have fixed this, if you push another change let's see

@alexrudall alexrudall merged commit e06565a into alexrudall:main Jun 10, 2024
7 checks passed
@alexrudall
Copy link
Owner

Thanks again @drnic - released in v7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants