Language related issues. #1484
Closed
Language related issues. #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing line
Correct a typo and add a missing line
|
Great thanks!
|
alextselegidis
requested changes
Apr 8, 2024
| @@ -1,5 +1,8 @@ | |||
| <?php defined('BASEPATH') or exit('No direct script access allowed'); | |||
| // Arabic | |||
| $lang['no_username_value_provided'] = 'No username value provided.'; | |||
There was a problem hiding this comment.
Please remove no_username_value_provided and no_password_value_provided and move invalid_credentials_provided to the end of the file before // End
application/controllers/Login.php
Outdated
| @@ -59,19 +59,19 @@ public function validate() | |||
| $username = request('username'); | |||
|
|
|||
| if (empty($username)) { | |||
| throw new InvalidArgumentException('No username value provided.'); | |||
| throw new InvalidArgumentException(lang('no_username_value_provided')); | |||
There was a problem hiding this comment.
This does not need to be translated because the JS will not allow for empty username submissions any longer
application/controllers/Login.php
Outdated
| } | ||
|
|
||
| $password = request('password'); | ||
|
|
||
| if (empty($password)) { | ||
| throw new InvalidArgumentException('No password value provided.'); | ||
| throw new InvalidArgumentException(lang('no_password_value_provided')); |
There was a problem hiding this comment.
This does not need to be translated because the JS will not allow for empty username submissions any longer
|
Changed as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language related updates