Flood fill in java

[harper0201]

add java code for implementation of flood fill

[Amaras]

Hi, thank you for your interest in the Algorithm Archive!
We will try to review your code as quickly as possible to get it merged in if we feel your code is high enough quality.

However, the first step of admissibility is not yet reached: you need to get your code to compile on a Docker Ubuntu-based environment, which, as I am writing this, just failed.
Below is the full error (slightly reformatted):

contents/flood_fill/code/java/main.java:5: error: cannot find symbol
        flood_fill f = new flood_fill();
        ^
  symbol:   class flood_fill
  location: class main

contents/flood_fill/code/java/main.java:5: error: cannot find symbol
        flood_fill f = new flood_fill();
                                   ^
  symbol:   class flood_fill
  location: class main

contents/flood_fill/code/java/main.java:6: error: cannot find symbol
        Point start = new Point(0,0);
        ^
  symbol:   class Point
  location: class main

contents/flood_fill/code/java/main.java:6: error: cannot find symbol
        Point start = new Point(0,0);
                                    ^
  symbol:   class Point
  location: class main

Please fix it, so we can review and eventually merge your code in.

[harper0201]

Hi,
Thanks for your patience. I just committed a new version which is already tested in my ubuntu-based environment. Please help check it.

[Amaras]

Thank you for the reactivity (relative to timezones, of course)!
If this compiles, I'll try to get someone to review it :)

[Amaras]

I checked your code before going to sleep, and it was empty.
Apparently your last commit truncated your flood_fill.java file, and outright deleted your Main.java file.
Please fix that, so we can review your code

[harper0201]

Hi,
Thanks for your time and patience. Maybe because I did something wrong about git operations, so it became a empty file. I have already fixed it. Could you please check it again ?

[Amaras]

Okay, so while I'm not a Java specialist, the code was clear enough for me to approve it. I would ask for a second opinion, but I don't know anyone who is comfortable enough reviewing Java code :/
The only thing that annoys me is your package thing, but apart from that, I have nothing to say about the code.

[Amaras]

maybe you can just do:

Suggested change

	if (p.x < 0 || p.x >= row || p.y < 0 || p.y >= col) return false;
	return true;
	return (p.x < 0 || p.x >= row || p.y < 0 || p.y >= col);

[Amaras]

sorry, wrong call: it was missing a ! operator before the parenthesis...

Error in the suggestions

[Amaras]

So, since you didn't respond to my last few comments, here is a new review.
Since you removed one line when removing the if statement in inbound(), you'll need to adjust the line numbers as well.
Looking forward to your next commit.

[Amaras]

Sorry I mislead you earlier, this should be the correct way:

Suggested change

	return (p.x < 0 || p.x >= row || p.y < 0 || p.y >= col);
	return !(p.x < 0 || p.x >= row || p.y < 0 || p.y >= col);