Update sourcepawn submodule #2146
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvander
approved these changes
May 1, 2024
|
Looks like there are some build errors, I'll try to address those in SP this week. |
|
Oh, you just need to bump the AMTL version in your PR. That should fix it. |
|
Sorry for the late commit. I hadn't realized that you had responded until now. |
|
The mock test is failing due to it using "any" ( however, I don't know if it's a regression or it was intentional ). If we were to change it to "int", it'd compile & correctly sort the array. However, I've noticed that the with the latest spcomp the plugin prints gibberish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error reported in #2145 has been fixed in alliedmodders/sourcepawn@9594f99.
This PR just updates the submodule to the latest remote commit ( I have not personally compiled & tested it ).