Allow goaccess to be cross compiled. #2038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cross compiling, bin2c needs to be built for the build system, so building it with the CC compiler won't work. We use an autoconf macro in order to obtain a good value for CC_FOR_BUILD, and define a rule using it directly instead. Reference https://www.gnu.org/software/autoconf-archive/ax_cc_for_build.html
|
CI seems to be failing because |
3 tasks
|
Thanks for submitting this and sorry for the delay. Are you able to avoid the Yeah I did not include the compression part as an option. Do you need it in your case? Thanks again! |
allinurl
force-pushed
the
master
branch
2 times, most recently
from
0550432
to
b1332f5
Compare
allinurl
force-pushed
the
master
branch
5 times, most recently
from
3d5333b
to
6c68a6e
Compare
allinurl
force-pushed
the
master
branch
7 times, most recently
from
31e2ac1
to
c6199f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross compiling, bin2c needs to be built for the build system, so
building it with the CC compiler won't work. We use an autoconf macro in
order to obtain a good value for CC_FOR_BUILD, and define a rule using
it directly instead.
Reference
https://www.gnu.org/software/autoconf-archive/ax_cc_for_build.html
If you want to avoid the dependency on
autoconf-archivefor the new macro, the logic is reasonably easy to replicate.I noticed that
bin2c.chas some code for using bzip2, but I don't think that can be enabled in any way, at least for now?