feat(docker): made Apollo docker ready #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix little bugs regarding the password read and used viper instead * createFile will automatically create parents folder too now * The server won't kill itself when fails to scrape something * Expose the right port, set a default working dir and moved in all the necessary files in order to make a minimal working image * Docker container will be built without kindle and podcast integrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viperinsteadcreateFilewill automatically create parents folder too nownecessary files in order to make a minimal working image
You can try to build & play with the image with the following commands:
docker build -t test/test . && docker run --rm -p8993:8993 -ePASSWORD=supersecurepassword test/testI've used multi-stage docker build so that the final image is still slim!
I used
viperinstead of your library since this way you can either set the password via environment variable or via.envfile.viperwill perform transparently the variable override so it will give more flexibility to the server while keeping the codebase simple!I hope this helps the project somehow 馃挭