Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Remove custom event and replay behavior. #55695

Closed
wants to merge 1 commit into from
Closed

refactor(core): Remove custom event and replay behavior. #55695

wants to merge 1 commit into from

Conversation

tbondwilkinson
Copy link
Contributor

These behaviors have been moved back to g3.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

@tbondwilkinson tbondwilkinson force-pushed the jsaction-custom-event-removal branch from b3cfc77 to bf00088 Compare May 6, 2024 22:23
@tbondwilkinson
Copy link
Contributor Author

TESTED=TGP

@tbondwilkinson tbondwilkinson force-pushed the jsaction-custom-event-removal branch 2 times, most recently from 41bc51d to 980dd33 Compare May 8, 2024 21:23
@tbondwilkinson tbondwilkinson marked this pull request as ready for review May 8, 2024 21:24
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 8, 2024
@tbondwilkinson tbondwilkinson added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note area: core Issues related to the framework runtime labels May 8, 2024
@ngbot ngbot bot added this to the Backlog milestone May 8, 2024
@tbondwilkinson
Copy link
Contributor Author

tbondwilkinson commented May 8, 2024 •
edited

Caretaker note:

  • Copybara CL required to create sync CL: cl/631196825
  • BUILD changes required to patch into sync CL: cl/631207106

@tbondwilkinson tbondwilkinson requested review from rahatarmanahmed and Jesse-Good and removed request for Jesse-Good and atscott May 8, 2024 21:27
@pullapprove pullapprove bot requested a review from dylhunn May 8, 2024 21:27
@tbondwilkinson tbondwilkinson removed the request for review from Jesse-Good May 8, 2024 21:28
thePunderWoman
thePunderWoman approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: public-api, primitives, size-tracking

packages/core/primitives/event-dispatch/test/dispatcher_test.ts
@@ -219,7 +218,7 @@ describe('dispatcher test.ts', () => {
dispatcher.registerGlobalHandler('click', handler);

const eventInfo = createTestEventInfo({
event: createEvent({type: 'mousedown'} as Event),
event: new MouseEvent('mousedown', {bubbles: true, cancelable: true}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to add support for Blossom and Buttercup, too.

@pullapprove pullapprove bot requested a review from alxhub May 8, 2024 21:33
AndrewKushnir
AndrewKushnir approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

goldens/size-tracking/integration-payloads.json Outdated Show resolved Hide resolved
@tbondwilkinson tbondwilkinson force-pushed the jsaction-custom-event-removal branch from 980dd33 to 4549f92 Compare May 9, 2024 19:53
@tbondwilkinson tbondwilkinson added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 9, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented May 9, 2024 •
edited

@tbondwilkinson this PR conflicts with the main branch (a golden file needs an update (likely a revert)) after merging #55587. Could you please rebase and remove the "cleanup" label from this PR when you get a chance?

@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 9, 2024
@tbondwilkinson tbondwilkinson force-pushed the jsaction-custom-event-removal branch from 4549f92 to d7f7985 Compare May 9, 2024 22:15
@pullapprove pullapprove bot requested a review from thePunderWoman May 9, 2024 22:15
@tbondwilkinson tbondwilkinson force-pushed the jsaction-custom-event-removal branch from d7f7985 to 40f76d0 Compare May 9, 2024 22:23
@tbondwilkinson tbondwilkinson removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 9, 2024
@tbondwilkinson
Copy link
Contributor Author

@tbondwilkinson this PR conflicts with the main branch (a golden file needs an update (likely a revert)) after merging #55587. Could you please rebase and remove the "cleanup" label from this PR when you get a chance?

Done!

@tbondwilkinson tbondwilkinson force-pushed the jsaction-custom-event-removal branch from 40f76d0 to e4b0c88 Compare May 9, 2024 22:40
@tbondwilkinson
refactor(core): Remove custom event and replay behavior.
40a3d8b 
These behaviors have been moved back to g3.
@tbondwilkinson tbondwilkinson removed the request for review from thePunderWoman May 12, 2024 02:43
atscott pushed a commit that referenced this pull request May 13, 2024
@tbondwilkinson @atscott
refactor(core): Remove custom event and replay behavior. (#55695)
eb31f2c 
These behaviors have been moved back to g3.

PR Close #55695
@atscott atscott closed this in 76d0aea May 13, 2024
@atscott
Copy link
Contributor

atscott commented May 13, 2024

This PR was merged into the repository by commit 76d0aea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@rahatarmanahmed rahatarmanahmed rahatarmanahmed approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: event dispatch merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note requires: TGP This PR requires a passing TGP before merging is allowed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tbondwilkinson @AndrewKushnir @atscott @thePunderWoman @rahatarmanahmed