fix(devtools): catch invalidated extension error #55697
Open
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from spamming console When a browser extension is updated it becomes invalidated on currently open pages. If that extension then tries to send a message to those pages through `chrome.runtime.sendMessage(..)` then an error is thrown in the console For Angular DevTools, this results in spamming the console with "Uncaught Error: Extension context invalidated." errors. This commit catches that error and removes the event listener that triggers the `chrome.runtime.sendMessage(...)` call.
AleksanderBodurri
added
target: patch
sumitarora
approved these changes
May 7, 2024
dgp1130
approved these changes
May 7, 2024
| chrome.runtime.sendMessage(event.data); | ||
| } catch (e) { | ||
| const {message} = e as Error; | ||
| if (message === 'Extension context invalidated.') { |
There was a problem hiding this comment.
Suggestion: message.includes('Extension context invalidated') would be a little less brittle to changes in the browser.
Am I correct in assuming there's no error code or other stable identifier we could use to recognize such errors? Is error message the only option we have here?
| @@ -8,11 +8,21 @@ | |||
|
|
|||
| /// <reference types="chrome"/> | |||
|
|
|||
| window.addEventListener('message', (event: MessageEvent) => { | |||
| const eventListener = (event: MessageEvent) => { | |||
There was a problem hiding this comment.
Style: A more descriptive name would be helpful here. Maybe sendMessageToBackgroundScript, proxyMessage, propagateMessage, or just onMessage if we can't come up with anything better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a browser extension is updated it becomes invalidated on currently open pages. If that extension then tries to send a message to those pages through
chrome.runtime.sendMessage(..)then an error is thrown in the console.For Angular DevTools, this results in spamming the console with "Uncaught Error: Extension context invalidated." errors.
This commit catches that error and removes the event listener that triggers the
chrome.runtime.sendMessage(...)call.