fix(forms): Make NgControlStatus host bindings OnPush compatible
#55720
+241
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: forms
requires: TGP
atscott
force-pushed
the
formshostbindingsonpush
branch
4 times, most recently
from
5e83ed8
to
90a620a
Compare
This was referenced May 11, 2024
This commit makes the host bindings of `NgControlStatus[Group]` compatible with `OnPush` components. Note that this intentionally _does not_ expose any new APIs in the forms module. The goal is only to remove unpreventable `ExpressionChangedAfterItHasBeenCheckedError` in the forms code that developers do not have control over.
atscott
force-pushed
the
formshostbindingsonpush
branch
4 times, most recently
from
87f6c44
to
dbb8263
Compare
atscott
force-pushed
the
formshostbindingsonpush
branch
from
dbb8263
to
2911043
Compare
pullapprove
bot
removed
the
requires: TGP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the host bindings of
NgControlStatus[Group]compatible withOnPushcomponents. Note that this intentionally does not expose any new APIs in the forms module. The goal is only to remove unpreventableExpressionChangedAfterItHasBeenCheckedErrorin the forms code that developers do not have control over.