Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(forms): remove deprecated symbols #55723

Closed
wants to merge 1 commit into from
Closed

refactor(forms): remove deprecated symbols #55723

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Follow-up of #55698 to help remove the symbols from G3.

@AndrewKushnir AndrewKushnir self-assigned this May 8, 2024
@AndrewKushnir AndrewKushnir self-requested a review May 8, 2024 01:21
@AndrewKushnir AndrewKushnir mentioned this pull request May 8, 2024
Closed
@AndrewKushnir
Copy link
Contributor

FYI, justification for symbols removal can be found in #55698 (comment).

@AndrewKushnir AndrewKushnir added this to the v18 final milestone May 9, 2024
@ngbot ngbot bot removed this from the v18 final milestone May 9, 2024
@AndrewKushnir AndrewKushnir added this to the v18 final milestone May 9, 2024
@ngbot ngbot bot removed this from the v18 final milestone May 9, 2024
@JeanMeche JeanMeche marked this pull request as ready for review May 13, 2024 19:18
@JeanMeche JeanMeche force-pushed the fix/ctrl-events branch 2 times, most recently from 9ca81e3 to a9ae6d7 Compare May 13, 2024 23:39
@JeanMeche
refactor(forms): remove deprecated symbols
fe801f7 
Follow-up of angular#55698 to help remove the symbols from G3.
@JeanMeche JeanMeche added this to the v18 final milestone May 15, 2024
@ngbot ngbot bot removed this from the v18 final milestone May 15, 2024
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate area: forms labels May 16, 2024
@ngbot ngbot bot added this to the Backlog milestone May 16, 2024
@AndrewKushnir AndrewKushnir modified the milestones: Backlog, v18 final May 16, 2024
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 16, 2024
@AndrewKushnir
Copy link
Contributor

FYI, this PR is blocked by an internal cleanup in Google's codebase (CL).

AndrewKushnir
AndrewKushnir approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott May 16, 2024 18:09
@AndrewKushnir AndrewKushnir added the requires: TGP This PR requires a passing TGP before merging is allowed label May 16, 2024
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label May 16, 2024
atscott
atscott approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

thePunderWoman
thePunderWoman approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, public-api

@AndrewKushnir AndrewKushnir removed the request for review from alxhub May 17, 2024 04:15
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented May 17, 2024 •
edited

Global Presubmit. Status: "green".

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed state: blocked labels May 17, 2024
@AndrewKushnir
Copy link
Contributor

Caretaker note: cleanup in g3 is completed, the TGP is "green", this PR is ready for merge.

@dylhunn
Copy link
Contributor

dylhunn commented May 17, 2024

This PR was merged into the repository by commit eddb405.

@dylhunn dylhunn closed this in eddb405 May 17, 2024
dylhunn pushed a commit that referenced this pull request May 17, 2024
@JeanMeche @dylhunn
refactor(forms): remove deprecated symbols (#55723)
0e16654 
Follow-up of #55698 to help remove the symbols from G3.

PR Close #55723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atscott atscott atscott approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

@AndrewKushnir AndrewKushnir

Labels
action: merge The PR is ready for merge by the caretaker area: forms merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
v18 final
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JeanMeche @AndrewKushnir @dylhunn @atscott @thePunderWoman