refactor(zone.js): remove legacy browser support #55745
Open
+32
−1,105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the support for legacy browsers. BREAKING CHANGE: IE/Non-Chromium Edge are not supported anymore.
angular-robot
bot
added
the
detected: breaking change
AndrewKushnir
approved these changes
May 9, 2024
| @@ -46,18 +46,6 @@ module.exports = function (config, ignoredLaunchers) { | |||
| // 'SL_IOS9': {base: 'SauceLabs', browserName: 'iphone', platform: 'OS X 10.10', version: | |||
| // '9.3'}, | |||
| 'SL_IOS10': {base: 'SauceLabs', browserName: 'iphone', platform: 'OS X 10.10', version: '10.3'}, | |||
There was a problem hiding this comment.
nit for some followup PRs: we may need to update the list of supported browsers and corresponding versions, it looks like some of the browsers in the list are pretty old.
There was a problem hiding this comment.
I'm not even sure this config is used.
It seems the zone.js saucelabs tests run the same versions as the FW (Android 11/12). See https://github.com/angular/angular/actions/runs/9021600666/job/24789278467?pr=55745
There was a problem hiding this comment.
Sounds good, we can revisit testing config and update it in a followup PR.
AndrewKushnir
added
target: rc
AndrewKushnir
added
the
action: presubmit
AndrewKushnir
added
the
requires: TGP
pullapprove
bot
removed
the
requires: TGP
AndrewKushnir
added
target: major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the support for legacy browsers.
BREAKING CHANGE: IE/Non-Chromium Edge are not supported anymore.
Fixes #46773