Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a note about development status of zone.js #55746

Closed
wants to merge 1 commit into from
Closed

docs: add a note about development status of zone.js #55746

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: zones target: rc This PR is targeted for the next release-candidate area: docs Related to the documentation labels May 10, 2024
@ngbot ngbot bot modified the milestone: Backlog May 10, 2024
@pullapprove pullapprove bot requested a review from JiaLiPassion May 10, 2024 00:38
@AndrewKushnir AndrewKushnir changed the title docs(zone.js): add a note about development status docs: add a note about development status of zone.js May 10, 2024
jelbourn
jelbourn approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-approvers

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 13, 2024
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented May 13, 2024 •
edited

Caretaker note: docs-only change, no additional approvals are required. This PR is ready for merge.

@atscott
Copy link
Contributor

atscott commented May 14, 2024

This PR was merged into the repository by commit 0eade1c.

atscott pushed a commit that referenced this pull request May 14, 2024
@AndrewKushnir @atscott
docs: add a note about development status of zone.js (#55746)
8902312 
PR Close #55746
@atscott atscott closed this in 0eade1c May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@alxhub alxhub Awaiting requested review from alxhub

@JiaLiPassion JiaLiPassion Awaiting requested review from JiaLiPassion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: zones merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndrewKushnir @atscott @jelbourn