refactor(core): Simplify event handler extraction logic. #55752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
approved these changes
May 10, 2024
AndrewKushnir
added
target: rc
AndrewKushnir
added
the
action: cleanup
iteriani
added
action: merge
AndrewKushnir
approved these changes
May 14, 2024
iteriani
force-pushed
the
simplify-event-replay
branch
from
7db61fc
to
33bf9fa
Compare
iteriani
force-pushed
the
simplify-event-replay
branch
2 times, most recently
from
f09d338
to
e0d9f99
Compare
… extraction logic. This should have been part of an earlier commit, but was not merged.
iteriani
force-pushed
the
simplify-event-replay
branch
from
e0d9f99
to
efdf25a
Compare
AndrewKushnir
approved these changes
May 15, 2024
There was a problem hiding this comment.
@iteriani do we need a new presubmit (regular, not a TGP one) for this change? I'm removing the "merge" label for now, please re-add if we've ran a presubmit already.
AndrewKushnir
removed
the
action: merge
|
this presubmit was actually done already, but for some reason only one of the commits got merged. |
AndrewKushnir
added
the
action: presubmit
|
FYI, I've started a new presubmit for the changes in this PR (since the other part of the change has landed separately). |
AndrewKushnir
added
action: merge
|
This PR was merged into the repository by commit d75adc5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reuses information already recorded during hydration to remove jsaction attributes to also stash event handlers. This avoids a tree walk and looku.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information