Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Move preventDefault to Dispatcher #55756

Closed
wants to merge 1 commit into from
Closed

refactor(core): Move preventDefault to Dispatcher #55756

wants to merge 1 commit into from

Conversation

tbondwilkinson
Copy link
Contributor

This is a simple move.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

@tbondwilkinson
Copy link
Contributor Author

TESTED=TGP

@tbondwilkinson tbondwilkinson marked this pull request as ready for review May 11, 2024 19:19
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 11, 2024
@tbondwilkinson
Copy link
Contributor Author

DIFFBASE=#55721

@tbondwilkinson tbondwilkinson added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime labels May 12, 2024
@ngbot ngbot bot modified the milestone: Backlog May 12, 2024
@tbondwilkinson tbondwilkinson added core: event dispatch target: rc This PR is targeted for the next release-candidate labels May 12, 2024
pkozlowski-opensource
pkozlowski-opensource approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from thePunderWoman May 13, 2024 11:41
thePunderWoman
thePunderWoman approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, primitives, public-api

@tbondwilkinson tbondwilkinson added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 14, 2024
@tbondwilkinson tbondwilkinson mentioned this pull request May 14, 2024
Closed
12 tasks
@atscott
Copy link
Contributor

atscott commented May 14, 2024

This PR was merged into the repository by commit caedd10.

@atscott atscott closed this in caedd10 May 14, 2024
atscott pushed a commit that referenced this pull request May 14, 2024
@tbondwilkinson @atscott
refactor(core): Move preventDefault to Dispatcher (#55756)
3b1b4e2 
This is a simple move.

PR Close #55756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@rahatarmanahmed rahatarmanahmed rahatarmanahmed approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: event dispatch requires: TGP This PR requires a passing TGP before merging is allowed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tbondwilkinson @atscott @pkozlowski-opensource @thePunderWoman @rahatarmanahmed @AndrewKushnir