Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

I've edited the external_download function #725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alsira
Copy link

@Alsira Alsira commented Dec 14, 2021

Hello, I've modified a bit of the external downloader code so it can handle some simple errors so far. It works as normal and everything. It should recover on linux if aria2c needs root access to do some I/O and even create directories now.

Thanks for this awesome repo though. 馃榿馃榿

This was edited so that the function could handle the errors as they came before leaving.
This doesn't include fatal errors such as if the resource cannot be found.
@nate-moo
Copy link
Contributor

I don't believe that running shit as root is in the best interest of the end user as that could potentially brick or cause a malfunction in the system, especially if the user isn't particularly adept at computers.

For example aria could overwrite an essential file if the user is trying to download to a restricted directory.

@ArjixWasTaken
Copy link
Collaborator

I don't believe that running shit as root is in the best interest of the end user as that could potentially brick or cause a malfunction in the system, especially if the user isn't particularly adept at computers.

For example aria could overwrite an essential file if the user is trying to download to a restricted directory.

You think a linux user wouldn't be adept at computers?

@nate-moo
Copy link
Contributor

I don't believe that running shit as root is in the best interest of the end user as that could potentially brick or cause a malfunction in the system, especially if the user isn't particularly adept at computers.
For example aria could overwrite an essential file if the user is trying to download to a restricted directory.

You think a linux user wouldn't be adept at computers?

yes, some might. Don't underestimate the power of the human brain, and plus installing linux is much easier now as it can basically just be 8 1/2 clicks and you're installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants