Indicate tower_cli.cfg can also be in current directory #15092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:awx_collection
fosterseth
reviewed
Apr 17, 2024
| @@ -54,6 +54,7 @@ These can be specified via (from highest to lowest precedence): | |||
| - direct module parameters | |||
| - environment variables (most useful when running against localhost) | |||
| - a config file path specified by the `tower_config_file` parameter | |||
| - a config file at `./tower_cli.cfg`, i.e. in the current directory | |||
There was a problem hiding this comment.
looking at the code more carefully, it looks like we walk the local directory and check for a tower_cli.cfg file there
for example, if my local directory is /home/sbf/awx, the code will check for
/home/tower_cli.cfg
/home/sbf/tower_cli.cfg
/home/sbf/awx/tower_cli.cfg
with the last one being highest priority
It looks like we never updated these docs to reflect that behavior though
maybe we can point that out here?
| ``` | ||
| host: https://localhost:8043 | ||
| verify_ssl: true | ||
| oauth_token: LEdCpKVKc4znzffcpQL5vLG8oyeku6 |
There was a problem hiding this comment.
Suggested change
| oauth_token: LEdCpKVKc4znzffcpQL5vLG8oyeku6 | |
| oauth_token: <token> |
leaving a real looking credential here might trip secret scanners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
tower_cli.cfgfile is also found in current directory.ISSUE TYPE
COMPONENT NAME