awxkit: replace deprecated locale.format() with locale.format_string() to fix human output on Python 3.12 #15170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealHaoLiu
approved these changes
May 22, 2024
|
CI failure is due to podman 5 upgrade, recently fixed that. I'm gonna rebase your PR to pickup the CI fix |
This will be removed in Python 3.12 and will break human output unless fixed.
|
@hb9hnt thanks for the contribution! approved and enabled auto-merge PR will merge once CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be removed in Python 3.12 and will break human output unless fixed.
SUMMARY
In Python 3.12 the deprecated function
locale.formtwas removed as mentioned here: python/cpython#94226This leads to an error on Python 3.12
as can be tested on Fedora >=39 or any machine running Python 3.12.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
awxcli: