Replace REMOTE_ADDR with ansible_base.lib.utils.requests.get_remote_host #15175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmzoneill
force-pushed
the
ansible_base.lib.utils.requests.get_remote_host
branch
from
7bce7b2
to
c6861b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Replace request.META.get('REMOTE_ADDR') with django-ansible-base get_remote_host
for environments with proxies and other intermediates where callbacks are broken because the remote_addr is the proxy.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
all