chore: upgrade electron #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add-penguinlab docs: add penguinlab as a contributor for translation
|
I don't really know my way around the repo so if there's something missing test or upgrade wise let me know |
|
There is a need to test if the whole build system is working properly and if there are breaking changes. |
|
Thanks @Fabio286 let me know if I can help with anything |
|
I tried your PR and i have some issues running Antares. I have to go deeper and check electron breaking changes after version 26. |
|
Ok, issues disappeared updating @electron/remote to latest. |
|
@all-contributors add @mangas for code |
|
I've put up a pull request to add @mangas! 🎉 |
|
awesome! thanks for checking 🙌 @Fabio286 do you mind tagging a release so we can use this on flathub? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be great to upgrade to a newer version of electron so we can use the following on wayland
https://www.electronjs.org/docs/latest/api/environment-variables#electron_ozone_platform_hint-linux