fix(terragrunt_validate): Only run terragrunt_validate in valid direc… #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tories (antonbabenko#191) The command fails if there is no terragrunt.hcl file in the directory.
yermulnik
reviewed
Jan 3, 2022
| @@ -82,7 +82,7 @@ | |||
| description: Validates all Terragrunt configuration files. | |||
| entry: terragrunt_validate.sh | |||
| language: script | |||
| files: (\.hcl)$ | |||
| files: (/terragrunt\.hcl)$ | |||
There was a problem hiding this comment.
Irrespective to the goal of the PR: parentheses are redundant here (as there's no grouping), forward slash needs to be escaped (as it is a special char in regex), and possibly files w/o path need to be taken into account (?):
Suggested change
| files: (/terragrunt\.hcl)$ | |
| files: (^|\/)terragrunt\.hcl$ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tories (#191)
The command fails if there is no terragrunt.hcl file in the directory.
Put an
xinto the box if that apply:Description of your changes
Fixes #191
How has this code been tested
Used this
filespattern locally in my.pre-commit-config.yamlfile and verified it no longer fails and still runs in desired directories. Using(/terragrunt\.hcl)$instead of(terragrunt\.hcl)$so files with aterragruntsuffix aren't matched, likeroot_terragrunt.hcl.