New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental change to accumulo cluster script to improve compactor and scan servers support for groups #4444
Draft
keith-turner
wants to merge
17
commits into
apache:2.1
Choose a base branch
from
keith-turner:accumulo-4424
base: 2.1
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-turner
added a commit
to keith-turner/accumulo
that referenced
this pull request
Apr 10, 2024
When trying to start and stop multiple groups of scan servers using the accumulo-cluster script the groups would interfere with each other. This change fixes that by making the the scan servers use the group in the instance id like compactors do. Ran into this while workiing on apache#4444 and pulled it out as a stand alone fix.
* Simplified the incremental naming logic for server types * Added error message when an invalid queue or group is passed when starting or stopping compactors and scan servers. * Updated list command in accumulo-service
Adds the list command to accumulo-service so running processes can be listed Modifies the kill and stop commands for accumulo-service so specific services can be stopped This improves on the current accumulo-service which would not locally stop or kill processes started by the accumulo-cluster script
Added a general `start-servers` and `stop-servers` commands to accumulo-cluster This simplifies the usage statement by reducing the number of unique commands Adds some general cleanup to accumulo-service
keith-turner
added a commit
that referenced
this pull request
Apr 11, 2024
When trying to start and stop multiple groups of scan servers using the accumulo-cluster script the groups would interfere with each other. This change fixes that by making the the scan servers use the group in the instance id like compactors do. Ran into this while workiing on #4444 and pulled it out as a stand alone fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked w/ @ddanielr on experimenting with changes for #4424 and #4425 that may not be merged into 2.1. We may eventually merge the changes into elasticity or main, not sure. Just posting this as a draft in case anyone is interested in seeing these experimental changes.