New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add balancer meter fixes #4470 #4471
base: 2.1
Are you sure you want to change the base?
Conversation
I confirmed that with uno instance configured to use a LoggingProvider, the meters appear in the manager metrics log:
|
4598f9c
to
d0d9997
Compare
core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java
Outdated
Show resolved
Hide resolved
balancerMetrics.setMigratingCount(params.migrationsOut().size()); | ||
balancerMetrics.setNeedMigrationCount(migrations.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that the migrations
variable in the Manager contains all of the in-flight migrations. The params.migrationsOut
contains the tablets that need to be migrated from this call to the balancer. I think based on what I'm seeing here, it's double counting. I wonder if we just want the size of the migrations
list as that will encompass newly added, newly removed, and migrations waiting to happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to capture the newly added migrations, then it might make sense to capture the migration completions (which are in the TabletGroupWatcher) and cancellations (which happen in a couple places in the Manager).
Adds two gauges that can be used to monitor balancing
This fixes #4470