Add integration test that ensures that server process does not start against newer version of accumulo. #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MiniAccumuloClusterImpl.verifyUp (called from start) should throw an IllegalStateException if the expected processes are not running. |
kevinrr888
reviewed
May 6, 2024
test/src/main/java/org/apache/accumulo/test/ServerVersionIT.java
Outdated
Show resolved
Hide resolved
test/src/main/java/org/apache/accumulo/test/ServerVersionIT.java
Outdated
Show resolved
Hide resolved
DomGarguilo
reviewed
May 17, 2024
Comment on lines
+84
to
+86
| // Check to see if both paths exist at the sametime | ||
| assertTrue(fs.exists(rootPath)); | ||
| assertTrue(fs.exists(newPath)); |
There was a problem hiding this comment.
Might be better to move this check before we check for the timeout
DomGarguilo
reviewed
May 17, 2024
Comment on lines
+71
to
+82
| ExecutorService executor = Executors.newSingleThreadExecutor(); | ||
| Future<?> future = executor.submit(() -> { | ||
| for (ServerType st : ServerType.values()) { | ||
| try { | ||
| getCluster().getClusterControl().start(st); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
| }); | ||
| // Check to see if servers fail to start | ||
| assertThrows(TimeoutException.class, () -> future.get(20, TimeUnit.SECONDS)); |
There was a problem hiding this comment.
I think this will only check that the first ServerType in ServerType.values() will timeout. We might want to create a future for each ServerType and check that each one times out. That will make this test pretty long but will make sure that none of them start up.
|
A more descriptive name for this IT might be better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the current moment, checking for errors while each server type starts up fails.
We should be expecting them to throw errors during start up since it should detect that there is a different version of hdfs, but at the moment they are not giving errors.
issue #4268