Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for scan server reservation write out time and collisions #4541

Closed

Conversation

DomGarguilo
Copy link
Member

Fixes #4509

This PR adds two new metrics:

  1. accumulo.scan.reservation.writeout.timer which records the amount of time it takes for reservations to be added to the metadata table
  2. accumulo.scan.reservation.collision.count which adds a FunctionCounter that gets incremented if a scan is held up waiting for files that are in flux

I also renamed accumulo.scan.reservation.timer to accumulo.scan.reservation.total.timer.

I have observed the writeout timer and total timer displayed in the metrics via logging:

METRICS: 2024-05-09T14:40:40,149, accumulo.scan.reservation.total.timer{host=localhost,instance.name=uno,port=9996,process.name=sserver,resource.group=default} throughput=1.666667/s mean=0.003309524s max=0.159866629s
METRICS: 2024-05-09T14:40:40,149, accumulo.scan.reservation.writeout.timer{host=localhost,instance.name=uno,port=9996,process.name=sserver,resource.group=default} throughput=0.033333/s mean=0.000017287s max=0.000017287s

I have not observed either the existing busy timeout counter or the new collision counter. If anyone has an ideas on how those might be able to be tested that would be helpful.

@DomGarguilo DomGarguilo self-assigned this May 9, 2024
@DomGarguilo DomGarguilo added this to In progress in 3.1.0 via automation May 9, 2024
@DomGarguilo DomGarguilo added this to In progress in 2.1.3 via automation May 9, 2024
@DomGarguilo
Copy link
Member Author

Closing as superseded by #4577

3.1.0 automation moved this from In progress to Done May 20, 2024
2.1.3 automation moved this from In progress to Done May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.1.3
Done
3.1.0
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Add scan server metrics to track reservation write times and collisions
1 participant