reduce the frequency that the list of scan servers is sorted #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provided plugin for working with scan servers sorts the list of scan servers fairly frequently. This list will not change too often, so it could be sorted less to offer a better amortized cost as the total number of scan servers grows. Also outside of the plugin, the plugin was being reset every 100ms. Removed this to give the plugin more control. Also there is currently no way to change client config for a created Accumulo client, so there is no need to recreate the plugin.
dlmarion
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided plugin for working with scan servers sorts the list of scan servers fairly frequently. This list will not change too often, so it could be sorted less to offer a better amortized cost as the total number of scan servers grows.
Also outside of the plugin, the plugin was being reset every 100ms. Removed this to give the plugin more control. Also there is currently no way to change client config for a created Accumulo client, so there is no need to recreate the plugin.