Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configuration drift with triggerer pvc #39180

Closed
wants to merge 1 commit into from

Conversation

vyas-n
Copy link

@vyas-n vyas-n commented Apr 22, 2024

The Persistence Volume Claim for the triggerer deployment (which is enabled by default with triggerer.persistence.enabled: true) doesn't fully specify the apiVersion & kind fields.

This can cause false warnings to appear for folks using GitOps tooling such as ArgoCD because the tool will indicate that the application is out-of-sync due to these fields when it actually isn't.

Screenshot 2024-04-22 at 16 13 22 Screenshot 2024-04-22 at 16 14 06

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Apr 22, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@vyas-n vyas-n changed the title fix: config drift with triggerer pvc fix: configuration drift with triggerer pvc Apr 22, 2024
@romsharon98
Copy link
Collaborator

The changes are correct but maybe the change should come in ArgoCD? because volumeClaimTemplate create a PersistentVolumeClaim implicitly without a need to mention it.

@vyas-n
Copy link
Author

vyas-n commented May 1, 2024

@romsharon98,

My bad, I did some digging and found that ArgoCD does have an option to fix this now called "Server-side Diff" https://argo-cd.readthedocs.io/en/stable/user-guide/diff-strategies/#server-side-diff

(source: argoproj/argo-cd#11143)

My issue is resolved for Airflow as a result.

I don't know if you'd like this PR to still be merged in or closed, but thanks for reviewing it!

@romsharon98
Copy link
Collaborator

@romsharon98,

My bad, I did some digging and found that ArgoCD does have an option to fix this now called "Server-side Diff" https://argo-cd.readthedocs.io/en/stable/user-guide/diff-strategies/#server-side-diff

(source: argoproj/argo-cd#11143)

My issue is resolved for Airflow as a result.

I don't know if you'd like this PR to still be merged in or closed, but thanks for reviewing it!

Glad to hear that you found your solution 😄
I am closing this PR since volumeClaimTemplate create a PersistentVolumeClaim implicitly and therefore it should not be mentioned.

@romsharon98 romsharon98 closed this May 1, 2024
@vyas-n vyas-n deleted the fix/config-drift-with-pvc branch May 1, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants