Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TIPydantic serialization of MappedOperator #39288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TIPydantic serialization of MappedOperator #39288

wants to merge 1 commit into from
+84 −7

Commits on Apr 27, 2024

  1. Fix TIPydantic serialization of MappedOperator 

    Previously we relied on SerializedBaseOperator.serialize_operator for serialization of all Operator objects but this is no bueno because it does not work for mapped operator.  Instead we use BaseSerialization.serialize, which calls the right method for each obj type.  To make this actually work for db isolation though, we had to do a few more things.  1. operator_class obj was not deserialized properly so fixed that. It's a weird case cus it roundtrips to a dict -- not a class.  Also expand_input did not work quite right because it roundtrips to _ExpandInputRef.  Then we had to make a small change to get_map_type_key since we might have _ExpandInputRef here.

(cherry picked from commit 65748fa)
    @dstandish
    dstandish committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    674601e View commit details
    Browse the repository at this point in the history