add deferrable support to DatabricksNotebookOperator
#39295
+83
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…db-notebook-deferrable-support Signed-off-by: kalyanr <kalyan.ben10@live.com>
…db-notebook-deferrable-support
…db-notebook-deferrable-support
pankajkoti
reviewed
May 6, 2024
rawwar
commented
May 6, 2024
Lee-W
reviewed
May 6, 2024
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W
reviewed
May 7, 2024
…db-notebook-deferrable-support
…db-notebook-deferrable-support
rawwar
commented
May 12, 2024
| "Task failed. Final state %s. Reason: %s", | ||
| run_state.result_state, | ||
| run_state.state_message, | ||
| f"Task failed. Final state {run_state.result_state}. Reason: {run_state.state_message}" |
There was a problem hiding this comment.
@pankajkoti , I updated this exception call. The reason is that AirflowException just extend the Base Exception class and all the extra arguments we send are not actually used to parse the final exception message.
example:
>>> from airflow.exceptions import AirflowException
>>> raise AirflowException("This is %s", "Hello")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
airflow.exceptions.AirflowException: ('This is %s', 'Hello')
Lee-W
approved these changes
May 13, 2024
| ) | ||
| operator.databricks_run_id = 12345 | ||
|
|
||
| with pytest.raises(TaskDeferred): |
There was a problem hiding this comment.
let's extend the test like this one
There was a problem hiding this comment.
Added it. Also added one more assert to check the method
…db-notebook-deferrable-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #39178
This PR intends to make
DatabricksNotebookOperatordeferrable