Handling exception getting logs when pods finish success #39296
+39
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniocorralsierra
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
antoniocorralsierra
force-pushed
the
handler_apiexception
branch
from
8c0afca
to
6b9bb1d
Compare
antoniocorralsierra
force-pushed
the
handler_apiexception
branch
from
82c40d8
to
628480a
Compare
amoghrajesh
reviewed
Apr 29, 2024
| def test_async_write_logs_handler_api_exception( | ||
| self, mock_manager, mocked_hook, mock_extract_xcom | ||
| ): | ||
| mock_manager.read_pod_logs.return_value = ApiException(status=404) |
There was a problem hiding this comment.
Can you also add for non status of 404?
|
Also static checks need fixing. The best way would be to set up pre commit locally as we mention in our contributors guidelines |
antoniocorralsierra
force-pushed
the
handler_apiexception
branch
from
32acac3
to
0d5987a
Compare
antoniocorralsierra
force-pushed
the
handler_apiexception
branch
from
0d5987a
to
ce7c310
Compare
amoghrajesh
approved these changes
May 1, 2024
There was a problem hiding this comment.
Changes look good, one nit from me, rest is OK +1
@hussein-awala WDYT?
| except ApiException as e: | ||
| if e.status == 404: | ||
| self.pod = None | ||
| self.log.info( |
|
can you rebase and resolve conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #39239
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.