use cached_property to reuse get_connections value in mssql provider
#39575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawwar
changed the title
cached_property to reuse get_connections valuecached_property to reuse get_connections value in mssql provider
potiuk
approved these changes
May 12, 2024
pateash
pushed a commit
to pateash/airflow
that referenced
this pull request
May 13, 2024
…vider (apache#39575) * use self.conn instead of calling get_connections * rename property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #39572
I was working on #39572 and had to call
get_connectionsand realised its been called multiple times in several functions. So, I thought it better to refactor and make it a cached_property and reuse it