-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2338] Incorrect display of props in hive upgrade page #2339
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2339 +/- ##
=========================================
Coverage 52.69% 52.69%
+ Complexity 4219 4214 -5
=========================================
Files 511 510 -1
Lines 29333 29308 -25
Branches 2851 2851
=========================================
- Hits 15456 15443 -13
+ Misses 12632 12620 -12
Partials 1245 1245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The title of the PR is supposed to be |
@@ -243,6 +243,7 @@ public void getUpgradeHiveTableProperties(Context ctx) throws IllegalAccessExcep | |||
AmsUtil.getNotDeprecatedAndNotInternalStaticFields(TableProperties.class); | |||
tableProperties.keySet().stream() | |||
.filter(key -> !key.endsWith("_DEFAULT")) | |||
.filter(key -> tableProperties.containsKey(key + "_DEFAULT")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, properties without default values will be ignored. I'm curious to know which specific parameters need to be ignored in this way. Would it be appropriate to consider handling these parameters through HIDDEN_EXPOSED?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By my count there are close to 30 props that need to be filtered.
|
shendanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Why are the changes needed?
Close #2338 .
Brief change log
-Modify the filter for props
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation