-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2438] Mixed Format KeyedTable support bin-packing splitting optimizing tasks #2446
base: master
Are you sure you want to change the base?
Conversation
@@ -146,14 +147,14 @@ public List<TaskDescriptor> planTasks() { | |||
double avgThreadCost = actualInputSize / availableCore; | |||
List<TaskDescriptor> tasks = Lists.newArrayList(); | |||
for (AbstractPartitionPlan partitionPlan : actualPartitionPlans) { | |||
tasks.addAll(partitionPlan.splitTasks((int) (actualInputSize / avgThreadCost))); | |||
tasks.addAll(partitionPlan.splitTasks((int) (partitionPlan.getCost() / avgThreadCost))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix calculating the target task count for each partition.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2446 +/- ##
============================================
+ Coverage 32.57% 32.59% +0.01%
+ Complexity 4469 4466 -3
============================================
Files 599 599
Lines 50306 50330 +24
Branches 6681 6687 +6
============================================
+ Hits 16388 16403 +15
- Misses 32614 32622 +8
- Partials 1304 1305 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Why are the changes needed?
Close #2438 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation