-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2656] Enhance TimeUtils and fix config parsing error #2657
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2657 +/- ##
============================================
+ Coverage 33.96% 34.12% +0.15%
- Complexity 4357 4377 +20
============================================
Files 604 605 +1
Lines 50754 50774 +20
Branches 6673 6668 -5
============================================
+ Hits 17241 17328 +87
+ Misses 32124 32043 -81
- Partials 1389 1403 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XBaith I left some comments. PTAL.
* | ||
* @param text string to parse. | ||
*/ | ||
public static Period parsePeriod(String text) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there are some unused methods here. Do we need to keep them?
ams/api/src/main/java/com/netease/arctic/api/config/DataExpirationConfig.java
Outdated
Show resolved
Hide resolved
We may need to remove one of the duplicated classes in |
+1 👍 |
# Conflicts: # ams/api/src/main/java/com/netease/arctic/api/config/DataExpirationConfig.java # ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java # ams/server/src/main/java/com/netease/arctic/server/table/DataExpirationConfig.java # ams/server/src/main/java/com/netease/arctic/server/table/TableConfiguration.java
# Conflicts: # ams/api/src/main/java/com/netease/arctic/api/config/ConfigHelpers.java
# Conflicts: # amoro-ams/amoro-ams-api/src/main/java/org/apache/amoro/api/config/DataExpirationConfig.java # amoro-core/src/main/java/org/apache/amoro/utils/TimeUtil.java # amoro-core/src/test/java/org/apache/amoro/utils/TestTimeUtil.java
Why are the changes needed?
Close #2656.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation