Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Arctic to Amoro for thrift name in module core #2801

Merged
merged 2 commits into from May 14, 2024

Conversation

zhongqishang
Copy link
Contributor

Why are the changes needed?

Change Arctic to Amoro for thrift name in module core

Brief change log

  • modify thrift file name
  • modify thrift class name
  • regenerate thrift code

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@xleoken
Copy link
Member

xleoken commented May 6, 2024

lgtm

@zhoujinsong
Copy link
Contributor

Hi

It seems this PR will make the older version client fail to connect to the server.
It may cause some problems when users try to upgrade to the new version.
Even if I think it is accepted as we have entered the ASF incubator and the next version will be a big new one and the name finally should be changed and this is a good time. But I still think we should discuss it in the dev mail list to make sure other developers and users know about it.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According the inputs from https://lists.apache.org/thread/swow5z1npcpq8j3yx4f5lhs0cr77fjlw, it is fine to merge this PR.

@zhoujinsong zhoujinsong merged commit bb8be9d into apache:master May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-optimizer AMS optimizer module module:core Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants