Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2787] Remove deprecated code for OptimizerConfig #2832

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

misselvexu
Copy link

Remove org.apache.amoro.optimizer.common.OptimizerConfig#memorySize and related code.

Why are the changes needed?

Close #2787.

Brief change log

  • Remove org.apache.amoro.optimizer.common.OptimizerConfig#memorySize and related code.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
    no.

@github-actions github-actions bot added the module:ams-optimizer AMS optimizer module label May 11, 2024
@zhongqishang
Copy link
Contributor

@misselvexu Thanks for your contribution.

I may not have stated it clearly, we just need to delete some of the code and documentation of the optimizer parameters.

The actual memory usage has changed from passing parameters to being calculated by the optimizer itself. This is not deleted immediately for compatibility, but it is no longer effective.

So we need to retain the parameters and calculation logic, and just delete the code associated with parameter parsing.

@misselvexu
Copy link
Author

@misselvexu Thanks for your contribution.

I may not have stated it clearly, we just need to delete some of the code and documentation of the optimizer parameters.

The actual memory usage has changed from passing parameters to being calculated by the optimizer itself. This is not deleted immediately for compatibility, but it is no longer effective.

So we need to retain the parameters and calculation logic, and just delete the code associated with parameter parsing.

I'll readjust it,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-optimizer AMS optimizer module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Remove deprecated code that needs to be removed in 0.7
2 participants