New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41581: [C++][CMake] correctly use Protobuf_PROTOC_EXECUTABLE #41582
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
|
Authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: H. Vetinari <h.vetinari@gmx.com>
@github-actions crossbow submit -g cpp r-binary-packages |
Revision: ec001f1 Submitted crossbow builds: ursacomputing/crossbow @ actions-ff0c327b41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks @h-vetinari
Gentle ping here :) |
ah sorry I lost track of this, Thanks! |
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit edd62f7. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…apache#41582) Fixes apache#41581 * GitHub Issue: apache#41581 Lead-authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Fixes #41581