Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41581: [C++][CMake] correctly use Protobuf_PROTOC_EXECUTABLE #41582

Merged
merged 1 commit into from May 15, 2024

Conversation

h-vetinari
Copy link
Contributor

@h-vetinari h-vetinari commented May 8, 2024

Copy link

github-actions bot commented May 8, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@h-vetinari h-vetinari changed the title [C++][CMake] correctly use Protobuf_PROTOC_EXECUTABLE GH-41581: [C++][CMake] correctly use Protobuf_PROTOC_EXECUTABLE May 8, 2024
Copy link

github-actions bot commented May 8, 2024

⚠️ GitHub issue #41581 has been automatically assigned in GitHub to PR creator.

Authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: H. Vetinari <h.vetinari@gmx.com>
@assignUser
Copy link
Member

@github-actions crossbow submit -g cpp r-binary-packages

Copy link

github-actions bot commented May 8, 2024

Revision: ec001f1

Submitted crossbow builds: ursacomputing/crossbow @ actions-ff0c327b41

Task Status
r-binary-packages GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks @h-vetinari

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 8, 2024
@h-vetinari
Copy link
Contributor Author

Gentle ping here :)

@raulcd raulcd merged commit edd62f7 into apache:main May 15, 2024
34 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label May 15, 2024
@assignUser
Copy link
Member

ah sorry I lost track of this, Thanks!

@h-vetinari h-vetinari deleted the protoc branch May 15, 2024 19:15
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit edd62f7.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++][CMake] handle Protobuf_PROTOC_EXECUTABLE correctly in cross-compilation
3 participants