Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][CMake] handle Protobuf_PROTOC_EXECUTABLE correctly in cross-compilation #41581

Closed
h-vetinari opened this issue May 8, 2024 · 1 comment · Fixed by #41582
Closed

[C++][CMake] handle Protobuf_PROTOC_EXECUTABLE correctly in cross-compilation #41581

h-vetinari opened this issue May 8, 2024 · 1 comment · Fixed by #41582
Assignees
@h-vetinari
Labels
Component: C++ Component: Packaging Type: bug
Milestone
17.0.0

Comments

@h-vetinari
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

In the preparation for releasing arrow v16 in conda-forge (where we need to cross-compile for various targets), @raulcd ended up raising #41333 which got fixed in #41360. However, as I was working on the backports, I noticed that there's a hunk missing here in apache/arrow compared to what got committed in conda-forge/arrow-cpp-feedstock@b80a399, namely

diff --git a/cpp/cmake_modules/FindProtobufAlt.cmake b/cpp/cmake_modules/FindProtobufAlt.cmake
index f343b42f2..98a3281ee 100644
--- a/cpp/cmake_modules/FindProtobufAlt.cmake
+++ b/cpp/cmake_modules/FindProtobufAlt.cmake
@@ -31,6 +31,12 @@ endif()
 find_package(protobuf CONFIG ${find_package_args})
 set(ProtobufAlt_FOUND ${protobuf_FOUND})
 if(ProtobufAlt_FOUND)
-  if(Protobuf_PROTOC_EXECUTABLE)
-    set_target_properties(protobuf::protoc PROPERTIES
-    IMPORTED_LOCATION_RELEASE "${Protobuf_PROTOC_EXECUTABLE}"
-  )
-  endif()
   set(ProtobufAlt_VERSION ${protobuf_VERSION})
   set(ProtobufAlt_VERSION_MAJOR ${protobuf_VERSION_MAJOR})
   set(ProtobufAlt_VERSION_MINOR ${protobuf_VERSION_MINOR})

Component(s)

C++, Packaging
@h-vetinari h-vetinari mentioned this issue May 8, 2024
Merged
raulcd added a commit that referenced this issue May 15, 2024
@h-vetinari @raulcd
GH-41581: [C++][CMake] correctly use Protobuf_PROTOC_EXECUTABLE (#41582)
edd62f7 
Fixes #41581
* GitHub Issue: #41581

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@raulcd raulcd added this to the 17.0.0 milestone May 15, 2024
@raulcd
Copy link
Member

raulcd commented May 15, 2024

Issue resolved by pull request 41582
#41582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-vetinari h-vetinari

Labels
Component: C++ Component: Packaging Type: bug
Projects
None yet
Milestone
17.0.0
Development

Successfully merging a pull request may close this issue.

GH-41581: [C++][CMake] correctly use Protobuf_PROTOC_EXECUTABLE h-vetinari/arrow
2 participants
@raulcd @h-vetinari