Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Support bit-sized types (BOOL) in fixed_width_util.h APIs #41596

Closed
felipecrv opened this issue May 8, 2024 · 1 comment
Closed

[C++] Support bit-sized types (BOOL) in fixed_width_util.h APIs #41596

felipecrv opened this issue May 8, 2024 · 1 comment
Assignees
@felipecrv
Labels
Component: C++ Type: enhancement
Milestone
17.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

After feedback given in #41297.

Component(s)

C++
@github-actions github-actions bot mentioned this issue May 8, 2024
Merged
felipecrv added a commit that referenced this issue May 14, 2024
@felipecrv
GH-41596: [C++] fixed_width_internal.h: Simplify docstring and suppor…
657c4fa 
…t bit-sized types (BOOL) (#41597)

### Rationale for this change

Post-merge feedback from #41297.

### What changes are included in this PR?

 - Supporting `BOOL` as both a top-level and nested in FSL types
 - Removing the long example from the docstring of `IsFixedWidthLike`

These changes don't affect users because this header was added recently and not released.

### Are these changes tested?

Yes, by existing and new test cases.
* GitHub Issue: #41596

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
@felipecrv felipecrv added this to the 17.0.0 milestone May 14, 2024
@felipecrv
Copy link
Contributor Author

Issue resolved by pull request 41597
#41597

vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@felipecrv @vibhatha
apacheGH-41596: [C++] fixed_width_internal.h: Simplify docstring and …
7ed5dba 
…support bit-sized types (BOOL) (apache#41597)

### Rationale for this change

Post-merge feedback from apache#41297.

### What changes are included in this PR?

 - Supporting `BOOL` as both a top-level and nested in FSL types
 - Removing the long example from the docstring of `IsFixedWidthLike`

These changes don't affect users because this header was added recently and not released.

### Are these changes tested?

Yes, by existing and new test cases.
* GitHub Issue: apache#41596

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
1 participant
@felipecrv