GH-41596: [C++] fixed_width_internal.h: Simplify docstring and support bit-sized types (BOOL) #41597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
8 tasks
felipecrv
force-pushed
the
fixed_width_fixups
branch
from
bb4ba0c
to
76a7784
Compare
pitrou
approved these changes
May 13, 2024
|
@felipecrv Do you want to merge this? |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 657c4fa. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…support bit-sized types (BOOL) (apache#41597) ### Rationale for this change Post-merge feedback from apache#41297. ### What changes are included in this PR? - Supporting `BOOL` as both a top-level and nested in FSL types - Removing the long example from the docstring of `IsFixedWidthLike` These changes don't affect users because this header was added recently and not released. ### Are these changes tested? Yes, by existing and new test cases. * GitHub Issue: apache#41596 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Post-merge feedback from #41297.
What changes are included in this PR?
BOOLas both a top-level and nested in FSL typesIsFixedWidthLikeThese changes don't affect users because this header was added recently and not released.
Are these changes tested?
Yes, by existing and new test cases.