Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41620: [Docs] Document merge.conf usage #41621

Merged
merged 6 commits into from May 17, 2024

Conversation

danepitkin
Copy link
Contributor

@danepitkin danepitkin commented May 10, 2024

Rationale for this change

As a new committer, I found that the usage of merge.conf was not documented and that a placeholder Jira token is still required, even though Arrow no longer uses Jira.

What changes are included in this PR?

  • Document merge.conf usage

Are these changes tested?

n/a

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #41620 has been automatically assigned in GitHub to PR creator.

@danepitkin
Copy link
Contributor Author

Do we still use this script for merging Parquet Jira issues?

@danepitkin danepitkin changed the title GH-41620: [Docs] Document merge.conf usage in merge script and remove Jira support GH-41620: [Dev][Docs] Document merge.conf usage in merge script and remove Jira support May 10, 2024
@danepitkin danepitkin marked this pull request as draft May 10, 2024 21:20
@assignUser
Copy link
Member

Do we still use this script for merging Parquet Jira issues?

A single one was merged in 16.0.0. There is an ongoing/pending thread on the parquet-ml https://lists.apache.org/thread/wvbg0tgx81xyxn5v2dgxt7b8l8o2sv4x
But there was vote called for now. I will bump the thread.

@danepitkin danepitkin changed the title GH-41620: [Dev][Docs] Document merge.conf usage in merge script and remove Jira support GH-41620: [Docs] Document merge.conf usage in merge script May 16, 2024
@danepitkin
Copy link
Contributor Author

I will leave Jira token scripts alone for now!

@danepitkin danepitkin marked this pull request as ready for review May 16, 2024 18:00
@danepitkin danepitkin changed the title GH-41620: [Docs] Document merge.conf usage in merge script GH-41620: [Docs] Document merge.conf usage May 16, 2024
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels May 16, 2024
@danepitkin danepitkin merged commit 8d687b0 into apache:main May 17, 2024
8 checks passed
@danepitkin danepitkin removed the awaiting committer review Awaiting committer review label May 17, 2024
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 8d687b0.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants