-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-6301] Extend ‘Must-filter’ columns to support a conditional … #3716
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the style checks I think this looks really solid
@@ -3894,32 +3894,37 @@ protected void validateSelect( | |||
|
|||
// Deduce which columns must be filtered. | |||
ns.mustFilterFields = ImmutableBitSet.of(); | |||
ns.mustFilterBypassFields = ImmutableBitSet.of(); | |||
if (from != null) { | |||
final Set<SqlQualified> qualifieds = new LinkedHashSet<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is qualifieds
== qualifiedFields
If so you could make it qualifiedFields
and qualifiedBypassFields
for consistency ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qualifieds
are qualifiedMustFilterFields
, yeah that could make it more clear
@olivrlee can you please fix the style issues which prevent the CI from passing? |
Sorry, I haven't had time to return to this. |
…bypass list