Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-6388] PsTableFunction throws NumberFormatException when the … #3777

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asolimando
Copy link
Member

…'user' column has spaces

Copy link

sonarcloud bot commented Apr 27, 2024

@snuyanzin
Copy link
Contributor

snuyanzin commented Apr 28, 2024

I guess the problem here that other columns also could contain space separated values like e.g. comm

I tried this ./sqlsh select distinct \`user\` from ps for the branch for this PR
and the output is

6.9
13.3
0.0
0.1
1.0
0.2
1.1
0.3
1.2
69.7
39.5
0.4
0.5
0.6
0.7
108
4.4
0.8
1.8
35.8
0.9

while for main same query is

message+
serg
avahi
lp
kernoops
root
rtkit
syslog
systemd+
colord

after some checks I noticed that command could also contain space separated values and probably this is the reason...

Copy link
Member

@caicancai caicancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests to illustrate the jira case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants