[Feature][DataSource]Add flink datasource plugin #15640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pegasas
force-pushed
the
issues/15630
branch
2 times, most recently
from
a213494
to
36503c2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| hosts.deleteCharAt(hosts.length() - 1); | ||
| flinkDataSourceParamDTO.setHost(hosts.toString()); | ||
| flinkDataSourceParamDTO.setPort(Integer.parseInt(hostPortArray[0].split(Constants.COLON)[1])); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
There was a problem hiding this comment.
Ack.
Thanks for calling out.
pegasas
force-pushed
the
issues/15630
branch
3 times, most recently
from
bd7929e
to
4ea5b38
Compare
|
Caused by: java.sql.SQLFeatureNotSupportedException: FlinkConnection#prepareStatement is not supported yet. will do some compacity work on sql task |
pegasas
force-pushed
the
issues/15630
branch
5 times, most recently
from
5314afb
to
14d308d
Compare
pegasas
requested review from
EricGao888,
Amy0104,
caishunfeng,
SbloodyS and
zhuangchong
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix: #15630
[Feature][Datasource] add flink datasource
Brief change log
Currently spark use thrift server for replacement of hiveserver2 to provide Spark SQL capability.
https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/sql-gateway/overview/
Flink SQL Gateway is also a replacement solution of hiveserver2.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md