[Fix-15668][Api]Fix data quality cannot get database/columns with kyuubi #15671
Conversation
SbloodyS
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15671 +/- ##
============================================
- Coverage 38.97% 38.96% -0.02%
Complexity 4839 4839
============================================
Files 1316 1316
Lines 45000 45015 +15
Branches 4817 4817
============================================
Hits 17539 17539
- Misses 25565 25580 +15
Partials 1896 1896 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| rs = metaData.getColumns( | ||
| getCatalog(dataSource.getType(), database), | ||
| getDbSchemaPattern(dataSource.getType(), database, schema, connectionParam), | ||
| tableName, "%"); |
Check failure
Code scanning / CodeQL
Query built from user-controlled sources High
| @@ -88,7 +88,7 @@ public String getDescp() { | |||
| } | |||
|
|
|||
| public boolean isHive() { | |||
| return this == DbType.HIVE; | |||
| return this == DbType.HIVE || this == DbType.KYUUBI; | |||
There was a problem hiding this comment.
May I ask why KYUUBI is also true in isHive()
There was a problem hiding this comment.
KYUUBI use spark engine to query hive table by default, using HiveReader is better.
|
Purpose of the pull request
resolves #15668
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md