Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](merge-cloud) fix single rowset did not trigger compaction in cloud mode #34622

Merged
merged 2 commits into from May 10, 2024
Merged

[fix](merge-cloud) fix single rowset did not trigger compaction in cloud mode #34622

merged 2 commits into from May 10, 2024

Conversation

luwei16
Copy link
Contributor

@luwei16 luwei16 commented May 9, 2024

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@luwei16
Copy link
Contributor Author

luwei16 commented May 9, 2024

run buildall

@luwei16
Copy link
Contributor Author

luwei16 commented May 9, 2024

run buildall

@gavinchou gavinchou requested a review from platoneko May 9, 2024 17:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.69% (8983/25172)
Line Coverage: 27.34% (74208/271461)
Region Coverage: 26.57% (38368/144380)
Branch Coverage: 23.39% (19567/83662)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6a7a4b3eebe251d04ee0f8e6f47aaec423302a9f_6a7a4b3eebe251d04ee0f8e6f47aaec423302a9f/report/index.html

dataroaring
dataroaring approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 38114ce into apache:master May 10, 2024
25 of 28 checks passed
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 10, 2024
M1saka2003 pushed a commit to M1saka2003/doris that referenced this pull request May 14, 2024
@luwei16 @M1saka2003
[fix](merge-cloud) fix single rowset did not trigger compaction in cl…
5076c61 
…oud mode (apache#34622)
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
@luwei16 @ByteYue
[fix](merge-cloud) fix single rowset did not trigger compaction in cl…
87f81fa 
…oud mode (apache#34622)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@platoneko platoneko Awaiting requested review from platoneko

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luwei16 @doris-robot @gavinchou @dataroaring