Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: that protoc-gen-go-triple cannot generate normally when a proto file has multiple services. #2647

Merged
merged 6 commits into from
May 16, 2024

Conversation

r27153733
Copy link
Contributor

fixed #2646

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.40%. Comparing base (2f5143a) to head (d313148).
Report is 4 commits behind head on main.

❗ Current head d313148 differs from pull request most recent head 5275c2c. Consider uploading reports for the commit 5275c2c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2647      +/-   ##
==========================================
+ Coverage   47.38%   47.40%   +0.02%     
==========================================
  Files         341      341              
  Lines       25122    25125       +3     
==========================================
+ Hits        11904    11911       +7     
+ Misses      12074    12069       -5     
- Partials     1144     1145       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DMwangnima DMwangnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a testcase to verify your change?

Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@baerwang baerwang requested a review from DMwangnima May 10, 2024 11:39
@chickenlj
Copy link
Contributor

The whole protoc plugin has been moved to a separate repo. I will merge this change first and move the source code there.

@chickenlj chickenlj merged commit fca0a3a into apache:main May 16, 2024
5 checks passed
Yuukirn pushed a commit to Yuukirn/dubbo-go that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protoc-gen-go-triple 在一个proto文件有多个service的情况下有bug
4 participants