[WIP] Support idl for hessian2 #2654
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2654 +/- ##
=======================================
Coverage 47.38% 47.39%
=======================================
Files 341 341
Lines 25122 25125 +3
=======================================
+ Hits 11904 11907 +3
+ Misses 12074 12072 -2
- Partials 1144 1146 +2 ☔ View full report in Codecov by Sentry. |
|
|
||
| g.P() | ||
|
|
||
| g.P("func ", "(x *", m.GoIdent.GoName, ")", "String() string {") |
There was a problem hiding this comment.
For now, we do not need this String() method since dubbo-go-hessian2 just make use of reflection to serialize.
In the future, we could generate serialization details to make it fast. (hessian2 FastCodec)
| // fieldGoType returns the Go type used for a field. | ||
| // | ||
| // If it returns pointer=true, the struct field is a pointer to the type. | ||
| func fieldGoType(g *protogen.GeneratedFile, field *protogen.Field) (goType string, pointer bool) { |
There was a problem hiding this comment.
Maybe isPointer is better?
| } | ||
|
|
||
| pointer = field.Desc.HasPresence() | ||
| switch field.Desc.Kind() { |
There was a problem hiding this comment.
We should discuss the mappings in details.
type serialization conversion: proto type => go type => java type
helping tool conversion: java interface file => proto file
e.g. Java does not support unsigned basic type, it would be complex when implementing helping tool if we decide to support unsigned basic type in proto and go.
|
Should we create a unique branch to track this working process. cc @chickenlj |
Yuukirn
force-pushed
the
feature-go-hessian2
branch
from
8319da0
to
9469cd8
Compare
Yuukirn
force-pushed
the
feature-go-hessian2
branch
from
9469cd8
to
4e34e05
Compare
| ErrNoExtendArgsRespFieldNum = errors.New("extend args for response message should has a field") | ||
| ) | ||
|
|
||
| type DubboGo struct { |
|
|
||
| package generator | ||
|
|
||
| import ( |
|
| @@ -22,15 +22,14 @@ import ( | |||
| ) | |||
|
|
|||
| import ( | |||
| "dubbo.apache.org/dubbo-go/v3/proto/hessian2_extend" | |||
|
Please submit a new pull request to https://github.com/dubbogo/protoc-gen-go-triple/ |
No description provided.